From cc88f0f81e85e53befef061e82ebac0825530e16 Mon Sep 17 00:00:00 2001 From: Elham Rababh Date: Sun, 3 Oct 2021 15:59:30 +0300 Subject: [PATCH] first step of fixing --- .../parmacyModule/parmacy_module_service.dart | 4 ++-- .../service/pharmacy_categorise_service.dart | 5 ++++- lib/pages/final_products_page.dart | 4 +++- .../screens/pharmacy_module_page.dart | 3 ++- .../pharmacies/widgets/manufacturerItem.dart | 18 +++++++++++------- 5 files changed, 22 insertions(+), 12 deletions(-) diff --git a/lib/core/service/parmacyModule/parmacy_module_service.dart b/lib/core/service/parmacyModule/parmacy_module_service.dart index 72bc56c7..d982c519 100644 --- a/lib/core/service/parmacyModule/parmacy_module_service.dart +++ b/lib/core/service/parmacyModule/parmacy_module_service.dart @@ -121,9 +121,9 @@ class PharmacyModuleService extends BaseService { manufacturerList.clear(); response['manufacturer'].forEach((item) { Manufacturer manufacturer = Manufacturer.fromJson(item); - if (manufacturer.image != null) { + // if (manufacturer.image != null) { manufacturerList.add(Manufacturer.fromJson(item)); - } + // } }); }, onFailure: (String error, int statusCode) { hasError = true; diff --git a/lib/core/service/pharmacy_categorise_service.dart b/lib/core/service/pharmacy_categorise_service.dart index c13f0548..e3ae4c81 100644 --- a/lib/core/service/pharmacy_categorise_service.dart +++ b/lib/core/service/pharmacy_categorise_service.dart @@ -329,6 +329,7 @@ class PharmacyCategoriseService extends BaseService { } Future getMostViewedProducts() async { + hasError = false; Map queryParams = { 'fields': 'id,discount_ids,name,reviews,namen,localized_names,display_order,short_description,full_description,full_descriptionn,sku,order_minimum_quantity,order_maximum_quantity,price,old_price,images,is_rx,rx_message,rx_messagen,discount_name,discount_namen,approved_rating_sum,approved_total_reviews,allow_back_in_stock_subscriptions,stock_quantity,stock_availability,stock_availabilityn,discount_percentage', @@ -346,7 +347,9 @@ class PharmacyCategoriseService extends BaseService { super.error = error; }, queryParams: queryParams); } catch (error) { - throw error; + hasError = true; + super.error = error.toString(); + // throw error; } } diff --git a/lib/pages/final_products_page.dart b/lib/pages/final_products_page.dart index 843d1d56..78ed3383 100644 --- a/lib/pages/final_products_page.dart +++ b/lib/pages/final_products_page.dart @@ -49,6 +49,8 @@ class _FinalProductsPageState extends State { Widget build(BuildContext context) { return BaseView( onModelReady: (model) { + + //TODO Elham* fix all services in order handel errors in better way in the service if (widget.productType == 1) { model.getFinalProducts(i: id); } else if (widget.productType == 2) { @@ -71,7 +73,7 @@ class _FinalProductsPageState extends State { isBottomBar: false, isShowAppBar: true, backgroundColor: Colors.white, - isShowDecPage: false, + isShowDecPage: true, baseViewModel: model, body: Container( height: MediaQuery.of(context).size.height * 5.87, diff --git a/lib/pages/pharmacies/screens/pharmacy_module_page.dart b/lib/pages/pharmacies/screens/pharmacy_module_page.dart index 9b91b77a..d21ee444 100644 --- a/lib/pages/pharmacies/screens/pharmacy_module_page.dart +++ b/lib/pages/pharmacies/screens/pharmacy_module_page.dart @@ -662,7 +662,8 @@ class _PharmacyPageState extends State { FadePage( page: FinalProductsPage( id: "", - productType: 4, + //TODO Elham* handel this to understans form where the number comming + productType: 20, ), ), ), diff --git a/lib/pages/pharmacies/widgets/manufacturerItem.dart b/lib/pages/pharmacies/widgets/manufacturerItem.dart index 574c37c5..a424512b 100644 --- a/lib/pages/pharmacies/widgets/manufacturerItem.dart +++ b/lib/pages/pharmacies/widgets/manufacturerItem.dart @@ -1,4 +1,5 @@ import 'package:diplomaticquarterapp/core/model/pharmacies/Manufacturer.dart'; +import 'package:diplomaticquarterapp/widgets/text/app_texts_widget.dart'; import 'package:diplomaticquarterapp/widgets/transitions/fade_page.dart'; import 'package:flutter/material.dart'; @@ -37,13 +38,16 @@ class ManufacturerItem extends StatelessWidget { left: BorderSide(color: Colors.grey.shade300, width: 1), top: BorderSide(color: Colors.grey.shade300, width: 1)), ), - child: Padding( - padding: EdgeInsets.symmetric(horizontal: 8), - child: Image.network( - item.image.src, - fit: BoxFit.cover, - ), - ), + ///TODO Elham* Improve design and check if they show the image and name or just name + child: item.image == null + ? Container(child: AppText(item.name)) + : Padding( + padding: EdgeInsets.symmetric(horizontal: 8), + child: Image.network( + item.image.src, + fit: BoxFit.cover, + ), + ), ), ), );